[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [fluid-dev] scaleTuning fix
From: |
Josh Green |
Subject: |
Re: [fluid-dev] scaleTuning fix |
Date: |
Tue, 06 Mar 2007 13:47:03 +0000 |
On Sat, 2007-03-03 at 23:30 +0200, Mihail Zenkov wrote:
> This patch fix case when scaleTuning == 0 (in SF21, page 47 -
> scaleTuning). Yamaha Konzert Piano.sf2 (from p2p) have this case.
>
Hello Mihail,
That does indeed look like a synthesis bug. I haven't yet applied this
though, since I think it might be better to set the GEN_PITCH generator
to the root note (instead of 0) in
fluid_voice_calculate_runtime_synthesis_parameters() when the value of
GEN_SCALETUNE is 0. That would perhaps remove the need to check this in
fluid_voice_write() and it isn't a real-time parameter. I might be
overlooking something though, let me know if you have any thoughts on
this. Thanks for the patch!
Josh Green