[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [fluid-dev] [PATCH] Effect level clip
From: |
Rui Nuno Capela |
Subject: |
Re: [fluid-dev] [PATCH] Effect level clip |
Date: |
Mon, 17 Sep 2007 23:10:24 +0100 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20070801) |
David Hilvert wrote:
> On Mon, 17 Sep 2007 21:06:36 +0100
> Rui Nuno Capela <address@hidden> wrote:
>
>> diff -dupr fluidsynth-1.0.7a.0/src/fluid_rev.c
>> fluidsynth-1.0.7a.1/src/fluid_rev.c
>> --- fluidsynth-1.0.7a.0/src/fluid_rev.c 2004-03-29 11:05:18.000000000
>> +0100
>> +++ fluidsynth-1.0.7a.1/src/fluid_rev.c 2006-02-21 23:01:12.000000000
>> +0000
>> @@ -535,8 +535,8 @@ void
>> fluid_revmodel_setlevel(fluid_revmodel_t* rev, fluid_real_t value)
>> {
>> /* fluid_clip(value, 0.0f, 1.0f); */
>> -/* rev->wet = value * scalewet; */
>> -/* fluid_revmodel_update(rev); */
>> + rev->wet = value * scalewet;
>> + fluid_revmodel_update(rev);
>> }
>
> It looks like omitting the clip might cause unbounded effect output levels.
> Note
> that svn 117 (perhaps earlier?) should resolve the pegged gain control
> problem.
yep, fluid_clip() call should have been uncommented too, but not really
a problem here, with qsynth at least, as the value is already been
restricted at the UI widget level.
cheers.
--
rncbc aka Rui Nuno Capela
address@hidden
- Re: [fluid-dev] [PATCH] Effect level clip, (continued)
- Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, Josh Green, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, Rui Nuno Capela, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, Josh Green, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, Josh Green, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, Josh Green, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17
- Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17
- Message not available
- Re: [fluid-dev] [PATCH] Effect level clip,
Rui Nuno Capela <=
Fw: Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17
Fw: Re: [fluid-dev] [PATCH] Effect level clip, David Hilvert, 2007/09/17