Re: [fluid-dev] [PATCH] Effect level clip

[Josh Green]

On Mon, 2007-09-17 at 17:42 -0500, David Hilvert wrote:
> On Mon, 17 Sep 2007 13:09:07 -0700
> Josh Green <address@hidden> wrote:
> 
> > return rev->wet / scalewet;
> > 
> > Probably could even remove the rev->level field at that point.  This
> > seems like the right way to do things.  Anyone got any objections or
> > comments on this?
> 
> If the 'wet' code is uncommented, and the effect level clip patch is reverted,
> does the gain control work as expected?  If so, the benefit of the effect 
> level
> clip patch is unclear; if not, the benefit of the commented code is unclear.
> 
> If the goal is solely to keep one of level and wet as an effect gain control,
> the answer should probably depend on which one works better for this.  OTOH,
> it's possible that wet is doing something else useful; could it be renamed?
> 

I think the wet parameter is related to how much of the "wet" reverb
signal is being mixed into the output.  Most of the magic is occurring
in the fluid_revmodel_processreplace() and fluid_revmodel_processmix()
functions.  I think its correct to use it as the level of the reverb,
although I'm not certain if it currently has the desired effect or not.
I'll enable it and we can do some tests with it.  Not sure why, by whom
or when that code got commented out.

Cheers.
        Josh