Re: [fluid-dev] Calls to fluid_log()

[Ceresa Jean-Jacques]

Hi,

 

> if someone will like the idea to cut the size without affecting the the quality of the sound rendering (like me),....

I like this idea too for future fanless embedded projects in mind (with high memory constraints).

In this regard, i hope this should be a good new. It seems it should be possible to reduce also the RAM size consumption by 588000 bytes (this is actually the maximum size of chorus's lfo table ).

This table (https://github.com/FluidSynth/fluidsynth/blob/7517c175240b31dd4470376575d9b4ac7cd2fba4/src/rvoice/fluid_chorus.c#L130) could be completelly removed and replaced by lfo wave fast computed on the fly (of course at the slight expense of cpu cycles (i hope)). I could propose a PR to address this "RAM size reduction" later (perhaps with further improvements (i.e stereo chorus)).

Cheers.

jjc

 

> > Message du 13/10/18 11:35
> > De : "Carlo Bramini" <address@hidden>
> > A : "FluidSynth mailing list" <address@hidden>
> > Copie à : 
> > Objet : Re: [fluid-dev] Calls to fluid_log()
> > 
> > Hello!
> > 
> > > Il 10 ottobre 2018 alle 13.53 "Tom M." <address@hidden> ha scritto:
> > > 
> > > > Since it comes for free, I do not see good reasons for not using FLUID_LOG macro also into those missing points.
> > > 
> > > I don't see good reasons for keeping it. IMO it's redundant and could be removed. Yet, I would accept a PR where FLUID_LOG is called everywhere. But you should add one of those "good reasons" as comment pointing out why to keep and use the macro rather than a direct function call. Otherwise it might get removed in a future cleanup.
> > > 
> > > And "removing logging completely" is not quite the reasoning I was hoping for, as it raises the question why anyone should do that.
> > 
> > Well, for people who wants to strip a bit the size of the binary, I discovered that by commenting the FLUID_LOG, I'm able to reduce the size of the executable from 1.26MB to 1.18MB, without changing the current code. I tried to do also the few missing fixes into the sources that still need to replace fluid_log() with FLUID_LOG macro and I commented the content of the logging functions. The size decreased again from 1.18MB to 1.17MB, not so much but actually the biggest part of the code is already using FLUID_LOG macro, so it is normal.
> > 
> > So, it depends... if someone will like the idea to cut the size without affecting the the quality of the sound rendering (like me), probably he won't disregard the chance to have this FLUID_LOG macro. Besides the space gain and the fact that it is 99% already done, I do not other good reasons. Afterall, since logging is a slow code, it not called in vital points and removing it does not seem to provide performance improvements.
> > 
> > Sincerely.
> > 
> > _______________________________________________
> > fluid-dev mailing list
> > address@hidden
> > https://lists.nongnu.org/mailman/listinfo/fluid-dev
> >