[Gnu-arch-users] Re: a decent-gnupatch detector (was: unsigned to signed archive conversion causing trouble?)

[Andreas Fuchs]

Today, Jan Hudec <address@hidden> wrote:
> On Tue, Jan 06, 2004 at 12:40:30 +0100, Ollivier Robert wrote:
>> The FreeBSD patch has been patched (:)) to deal with that a while
>> ago, before 4.6.
>>
>> revision 1.18 date: 2002/04/26 19:01:19; author: gad; state: Exp;
>> lines: +65 -1 Modify our 'patch' utility to recognize the \ No
>> newline at end of file line that some versions of diff print out if
>> the last line of the two files are different, and one of the two
>> files does not have a newline character on that last line.
>
> That is a good news. However, since a patch that recognize unified
> format, but not this line, ever existed, the feature should be
> tested.

Right. The script at <URL:http://boinkor.net/arch/patch-detect.2.sh>
now generates a "\No newline" test case, too.

I'm not too certain that we should test for every bug in the existence
of patch, though. Just testing for the most common show-stoppers
should be enough to provide a workable user experience.

Thanks for the suggestion,
-- 
Andreas Fuchs, <address@hidden>, address@hidden, antifuchs