gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnu-arch-users] Re: patch: automatic remove the corrupt revlib revision


From: Matthieu Moy
Subject: [Gnu-arch-users] Re: patch: automatic remove the corrupt revlib revision
Date: Wed, 30 Nov 2005 23:39:15 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Derek Zhou <address@hidden> writes:

> when inode sig checking fails, just rm -rf the revision 

Better

  mv revision ,,to-be-deleted
  rm -fr ,,to-be-deleted

since rmrf_file isn't atomic AFAIK, and a concurrent process might try
to access the revlib at the same time.

Also, this should give a warning message (I like the fact that baz
explains why the inode sig failed) so that the user can understand
what happens, and potentially solve the problem.

-- 
Matthieu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]