Re: [PATCH] ancient font accidentals and clef update

[Juergen Reuter]

On 27 Jul 2001, Jan Nieuwenhuizen wrote:

> ...
> Thanks.  It looks fine, but could you redo it leaving existing feta
> character names intact, ie, make it work without this:
> 
> > -fet_beginchar("Sharp" , "1", "sharp");
> > +fet_beginchar("Default Sharp" , "default1", "defaultsharp");

I *can* leave the names intact, but I highly recommend to change them for
backwards compatibility reasons of future lilypond versions:
My patch introduces a consistent naming scheme of the form 'style +
char_mnemonic', where, in the above case, style equals "default".  Leaving
the existing names intact means that you have to set style to "", which is
really awkward.  Of course, one could introduce code that checks if style
equals "default" and then internally patches it to be "", but that would
be a hack.  By now, character names like "default1" are used internally
only (in contrast to, e.g. notehead style) and may still be changed 
without creating any backwards compatibility problems.  Future versions,
however, will reveal part of the character name via the 'style' property,
so we have to be carefully now when introducing a naming scheme to be
adequate for future extensions.  Note that the same discussion will also
arise e.g. for flags style (to be implemented soon).

BTW., I agree that "default" is not a proper name; maybe something like
"contemporary" is more appropriate.  Any other suggestions?

> 
> Maybe you can also just send a full copy of ancient-font.ly, if you
> think the patch will reject.
> 

The problem is not that the patch for ancient-font.ly may reject, but
rather that there are now two branches in the line of development that
have to be re-united by applying a merge.  I just wanted to suggest me to
manually merge the two lines rather than you trying to merge it
automatically.  In other words, I just would like to submit yet another
patch for ancient-font.ly (either as diff or as full copy) as soon as the
rest of the two patches has made it into 1.5.x.  Is that ok?

Greetings,
            Juergen