Re: [PATCH] ancient font accidentals and clef update

[Han-Wen Nienhuys]

address@hidden writes:
> > Thanks.  It looks fine, but could you redo it leaving existing feta
> > character names intact, ie, make it work without this:
> > 
> > > -fet_beginchar("Sharp" , "1", "sharp");
> > > +fet_beginchar("Default Sharp" , "default1", "defaultsharp");
> 
> I *can* leave the names intact, but I highly recommend to change them for
> backwards compatibility reasons of future lilypond versions:
> My patch introduces a consistent naming scheme of the form 'style +
> char_mnemonic', where, in the above case, style equals "default".  Leaving

We have a fairly consistent convention that

   default == undefined

unless a definition is really necessary. There is a very clear
rationale for this: I want lily to work as much as possible even if
you remove leave out definitions, engravers, contexts etc.

Note that undefined in lily is associated with Scheme value '(), not
with "".

> patch for ancient-font.ly (either as diff or as full copy) as soon as the
> rest of the two patches has made it into 1.5.x.  Is that ok?

yep, sounds good.

-- 

Han-Wen Nienhuys   |   address@hidden    | http://www.cs.uu.nl/~hanwen/