Re: [gnugo-devel] Crash report for OS X Segmentation fault

[Gunnar Farneback]

Arend wrote:
> Compared to Gunnar's solution, this patch may need a little more memory
> but should be slightly faster. I have no strong feelings about which one
> might be preferrable.

This function should not be time-critical, so saving some more memory
is probably better. Furthermore...

> -  int result[MAX_BOARD * MAX_BOARD];
> -  static int moyo_is_adjacent[MAX_BOARD * MAX_BOARD][MAX_MOYOS + 1];
> +  int result[number_of_dragons];
> [...]
> +    int moyo_is_adjacent[number_of_dragons][moyos.number + 1];

...these declarations are not portable. Non-constant array sizes can
be used in gcc and possibly some more compiler but are not included in
standard C.

/Gunnar