guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47976] [PATCH 10/10] gnu: Add orange.


From: Leo Famulari
Subject: [bug#47976] [PATCH 10/10] gnu: Add orange.
Date: Fri, 23 Apr 2021 15:25:17 -0400

On Fri, Apr 23, 2021 at 05:28:16PM +0000, Vinicius Monego wrote:
> * gnu/packages/orange.scm (orange): New variable.
> +         (add-after 'unpack 'preparations
> +           (lambda _
> +             ;; Delete test that opens an outgoing connection.
> +             (delete-file "Orange/tests/test_url_reader.py")

Okay.

> +             ;; This is a binary file and it breaks runpath validation.
> +             (delete-file "Orange/tests/datasets/binary-blob.tab")
> +             ;; Skip the test which uses that binary file.
> +             (substitute* "Orange/tests/test_txt_reader.py"
> +               (("test_read_nonutf8_encoding") 
> "_test_read_nonutf8_encoding"))

If 'binary-blob.tab' is software, we should remove it in an origin
snippet. If it's just data, then it's fine to do it like this.

> +             ;; Relax some dependency versions.
> +             (substitute* "requirements-gui.txt" (("PyQtWebEngine>=5.12") 
> ""))

Isn't this unecessary? We have PyQtWebEngine 5.15.2.

> +             (substitute* "requirements-core.txt"
> +               (("httpx>=0.14.0,<0.17") "httpx"))

And for this, we have 0.16.1.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]