guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47976] [PATCH 10/10] gnu: Add orange.


From: Vinicius Monego
Subject: [bug#47976] [PATCH 10/10] gnu: Add orange.
Date: Fri, 23 Apr 2021 21:04:22 +0000

Leo Famulari writes:

>> +             ;; This is a binary file and it breaks runpath validation.
>> +             (delete-file "Orange/tests/datasets/binary-blob.tab")
>> +             ;; Skip the test which uses that binary file.
>> +             (substitute* "Orange/tests/test_txt_reader.py"
>> +               (("test_read_nonutf8_encoding") 
>> "_test_read_nonutf8_encoding"))
>
> If 'binary-blob.tab' is software, we should remove it in an origin
> snippet. If it's just data, then it's fine to do it like this.
>

It is just data.

>> +             ;; Relax some dependency versions.
>> +             (substitute* "requirements-gui.txt" (("PyQtWebEngine>=5.12") 
>> ""))
>
> Isn't this unecessary? We have PyQtWebEngine 5.15.2.
>

There's something with pyqtwebengine not being found. The check phase
will fail to find it if I don't remove it from requirements. The same
happened in the Spyder package, but in that case the executable would
complain. I'm not sure why this happens.

>> +             (substitute* "requirements-core.txt"
>> +               (("httpx>=0.14.0,<0.17") "httpx"))
>
> And for this, we have 0.16.1.

Ok, 0.17 has been out for a while now and I have an update for it, but
did not submit yet. I will leave this substitution for later then.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]