guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47976] [PATCH 00/10] Add Orange


From: Vinicius Monego
Subject: [bug#47976] [PATCH 00/10] Add Orange
Date: Fri, 23 Apr 2021 21:20:08 +0000

Leo Famulari writes:

> On Fri, Apr 23, 2021 at 05:25:47PM +0000, Vinicius Monego wrote:
>> This patchset adds the Orange data mining / data visualization / machine 
>> learning toolkit.
>> 
>> I had to disable tests for the orange widget base because unittest failed to 
>> load a file. But all tests for orange itself are passing.
>> 
>> Vinicius Monego (10):
>>   gnu: Add python-anyqt.
>>   gnu: Add python-pyqtgraph.
>>   gnu: Add python-qasync.
>>   gnu: Add python-orange-canvas-core.
>>   gnu: Add python-orange-widget-base.
>>   gnu: Add python-serverfiles.
>>   gnu: Add python-python-louvain.
>>   gnu: python-pynndescent: Update to 0.5.2.
>>   gnu: python-opentsne: Update to 0.5.2.
>>   gnu: Add orange.
>
> Thanks! I sent some comments.
>
> Otherwise, the patches look good to me, based on these standard
> assumptions:
>
> 1) You linted and built the packages
> 2) The packages are using the latest upstream versions
> 3) You checked that the licenses are correct

Thanks for the reminder. I spotted some issues.

- python-setuptools can be removed from the inputs of
  python-orange-canvas-core. The linter will also complain about
  python-docutils being propagated, but that is how it should be.
- python-qasync's license is bsd-2, not bsd-3.
- httpx doesn't need version substitution in orange (already commented
in the other reply).

Orange also states in the website that "non-code" parts are licensed
under CC-BY-SA (version not specified), if that's relevant:

https://orangedatamining.com/license/

All versions are up to date and all packages were built.

Should I send a v2 only for the affected patches?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]