guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54304] [PATCH] Don't fix git executable location during Elixir buil


From: Maxime Devos
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Date: Tue, 08 Mar 2022 23:22:42 +0100
User-agent: Evolution 3.38.3-1

Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
> * At run-time, Git is used by Mix if, and only if, there are any Git-based 
> dependencies. This
>   is not the normal case, and in that sense Git is an optional dependency of 
> Elixir - most
>   projects will work just fine without Git being present. Here, too, PATH + 
> `git` is used
>   so if there is a need on a user's system to use Git-based dependencies, the 
> user can just
>   add the package to the profile and things will just work.

If it's optional and not used most of the time, removing
it seems fine to me, though this seems useful information for the
description.  Also, it would be nice if 'elixir' were patched
to emit a nice message when 'git' is not found.  Suggestion:

  This project required 'git', but it is not in $PATH.  It can be
  installed into the user profile with `guix install git`.

You might want to contact whoever added the substitution originally,
to see what the original reasons were.

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]