[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54304] [PATCH] Don't fix git executable location during Elixir buil
From: |
Ludovic Courtès |
Subject: |
[bug#54304] [PATCH] Don't fix git executable location during Elixir build |
Date: |
Sun, 13 Mar 2022 23:14:19 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> Ludovic Courtès schreef op vr 11-03-2022 om 22:51 [+0100]:
>> If we know what set of store references go in those blogs, we could
>> create a text file or something in #$output whose sole purpose is to
>> keep a reference to those store items.
>>
>> For example, if we know those BEAM files contain a reference to Git, we
>> can add a phase like:
>>
>> (lambda* (#:key inputs outputs #:allow-other-keys)
>> (symlink (search-input-file inputs "git")
>
> Doesn't that need to be "bin/git" instead of "git"?
>
>> (string-append (assoc-ref output "out")
>> "/libexec/elixir/.git")))
>>
>> That way the GC will keep Git around.
>>
>> Thoughts?
>
> That is not sufficient if git acquires a graft.
Argh, good point.
Now, I agree with Cees that we need to be pragmatic here and opt for a
“good enough” solution.
So I went ahead and applied the initial patch that Cees posted.
However, that ‘replace-paths’ phase also touches references to /bin/sh;
are they also a problem after GC?
Thanks,
Ludo’.
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, (continued)
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Cees de Groot, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Ludovic Courtès, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Cees de Groot, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Cees de Groot, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Cees de Groot, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Cees de Groot, 2022/03/11
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build,
Ludovic Courtès <=
- [bug#54304] [PATCH] Don't fix git executable location during Elixir build, Cees de Groot, 2022/03/13
[bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/08
[bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/08
[bug#54304] [PATCH] Don't fix git executable location during Elixir build, Maxime Devos, 2022/03/08