guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54304] [PATCH] Don't fix git executable location during Elixir buil


From: Cees de Groot
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Date: Wed, 09 Mar 2022 17:29:21 +0000

>From the docs:

":revision - short Git revision hash. If Git was not available at building 
time, it is set to """ (https://hexdocs.pm/elixir/System.html#build_info/0)

So if git is not available - either because the executable is not there or 
because the build checkout is not from Git, the revision hash is set to the 
empty string, which is in accordance with the docs and what the Guix build has 
been doing all along (because, as you said, at build time, .git isn't there).

So for build time, cross-compiling or not, we don't need Git.

------- Original Message -------

On Wednesday, March 9th, 2022 at 02:31, Maxime Devos <maximedevos@telenet.be> 
wrote:

> Cees de Groot schreef op wo 09-03-2022 om 02:39 [+0000]:
>
> > > [...]
> > >
> > > That cannot ever have worked in the first place, since Guix
> > >
> > > does not save the '.git' directory when downloading elixir's source
> > >
> > > code.
>
> > That’s correct and fine. The info is informational at most
>
> How can being completely broken be correct and fine?
>
> Greetings,
>
> Maxime.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]