guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54293] [PATCH v2] home: Add home-git-service-type.


From: Maxime Devos
Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type.
Date: Sat, 12 Mar 2022 10:54:15 +0100
User-agent: Evolution 3.38.3-1

iyzsong@outlook.com schreef op za 12-03-2022 om 10:22 [+0800]:
> + (user.name
> +   (git-option-value *unspecified*))

I think *unspecified* is considered an implementation detail. Proposal:
let it be #false by default, and don't serialize the option whenever it
is #false.

Also, I don't think that user names can be #false, #true or integers. 
Perhaps a 'git-string-value' would be useful?

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]