guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54293] [PATCH v2] home: Add home-git-service-type.


From: Maxime Devos
Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type.
Date: Sat, 12 Mar 2022 11:31:43 +0100
User-agent: Evolution 3.38.3-1

iyzsong@outlook.com schreef op za 12-03-2022 om 10:22 [+0800]:
> +  (commit.gpgSign
> +   (git-option-value *unspecified*)

Would be nice to validate it's a boolean, and not, say, a string or
number.

> +   "A boolean to specify whether all commits should be GPG signed.")

I'm wondering, should 'gpg.program' be set instead of relying on $PATH?

Also, this can be overriden with "-S", so perhaps

  "A boolean specifying whether to sign commits by default, with
OpenPGP."

Also, the exact implementation (GPG) of OpenPGP used seems an
implementation detail, hence my suggestion GPG->OpenPGP.

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]