guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54293] [PATCH v2] home: Add home-git-service-type.


From: Maxime Devos
Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type.
Date: Sat, 12 Mar 2022 10:58:17 +0100
User-agent: Evolution 3.38.3-1

iyzsong@outlook.com schreef op za 12-03-2022 om 10:22 [+0800]:
> +  (user.email [...])
> +  (user.signingKey [...])
> +  (author.name [...])
> +  (author.email [...])
> +  (committer.name [...])
> +  (committer.email [...])

Conventionally (Guile) Scheme symbols are lowercase and don't use dots.
I suppose you could do 'user-signing-key'.

However, there seems to be quite some duplication between 'user',
'author' and 'committer'.  Perhaps you could abstract things a little
by e.g. doing something like the git-user-info record I proposed?

(home-git-configuration
  (user (git-user-info (name ...) (e-mail ...) (signing-key ...))
  (author user)
  (committer user)
  [other options])  

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]