[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libidn2 support

From: Tim Ruehsen
Subject: Re: libidn2 support
Date: Thu, 08 Dec 2016 16:14:56 +0100
User-agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.28.0; x86_64; ; )

On Wednesday, December 7, 2016 8:59:39 AM CET Simon Josefsson wrote:
> Den Tue, 06 Dec 2016 17:03:04 +0100
> skrev Re: libidn2 support:
> > On Monday, December 5, 2016 10:00:32 AM CET Simon Josefsson wrote:
> > > Hi again.  I have added you now.  There is no real work going on
> > > with libidn2, but Hanno Böck said he may have found more
> > > security vulnerabilities, so it would be nice to be able to do a
> > > quick security release if needed.  Therefor, it appears preferrable
> > > to push your stuff to a branch meanwhile.  I'm happy to review when
> > > it is on a branch, and hopefully we can make test releases from the
> > > branch too.
> > 
> > Hi Simon,
> > 
> > just put my stuff into 4 different branches within your Gitlab repo.
> Hi Tim.  Yay!
> > Please review/merge in this order:
> Very good to split things up, thank you.  Let's try to do low-hanging
> fruit one at a time.
> > # branch 'fixes'
> > - fix two crashes in lookup and register functions
> > - avoid tainting insertname/lookupname on error
> Can you write self-tests that trigger these issues?  That makes it much
> easier to evaluate the patches.

Added a branch 'coverage' based on branch 'libunistring'.

It contains a make target 'check-coverage' which runs the test suite with 
collection coverage stats and generating HTML output in directory 'lcov'.

It adds a NFC quick check to avoid unneeded normalizations (explained in

I also added a few tests to cover more code paths than before, raising 
coverage to:
  lines......: 88.8% (656 of 739 lines)
  functions..: 95.1% (39 of 41 functions)

That was the low hanging fruits, covering more code paths is beyond my time.
You could remove the case_flags from punycode_encode() - not used in libidn2.

Interestingly, ltr_ends_ok() in bidi.c is never called. That means 
ltr_lenescsetonbnnsm_ok() always returns false. Not sure what is going on 
here. Maybe just missing test cases - they added more cases for Unicode > 

Regards, Tim

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]