Re: [patch 1/2] 307-gary-fix-recursive-ltdl-dist-rules.diff

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 09:39:27PM CET:
> Argh! I seem to have posted an in development version of this patch
> somehow, sorry.  Here is the real patch.  If you had weird non-repeatable
> results in tests, and corrupted libltdl/Makefile.am before, this version
> doesn't have that problem.

Good.  

> Okay to commit this version?

No.  With this, in any of the three subproject/(non)recursive modes,
one of Makefile.{am,inc} will end up with a newer time stamp (and
Makefile.in won't match Makefile.am's contents).

This breaks your long work on making libltdl/subproject installable and
usable without Autoconf or Automake.  Even more, aclocal.m4 won't be out
of date, so aclocal won't be run, but a subsequent automake will fail if
its version doesn't match exactly the one you used to build Libtool.

Our installed Makefile.{am,in} should look exactly like they end up for
subproject, and not be modified for them, I believe.  The other modes do
not care about rerunning autotools: for them it is required anyway.

Cheers,
Ralf

> Index: libtool--devo--1.0/ChangeLog
> from  Gary V. Vaughan  <address@hidden>
>       * libltdl/Makefile.inc (EXTRA_DIST): Move files that are not
>       installed unconditionally to a client from here...
>       * Makefile.am (EXTRA_DIST): ...to here.
>       * libtoolize.m4sh: Append the paths to installed files to
>       EXTRA_DIST in newly copied Makefile.am.
>       (func_copy_cb): Add glob_nolink argument for files that cannot be
>       softlinked during ltdl installation.  Changed all callers.
>       * tests/libtoolize.at: Adjust output matching for glob_nolink
>       files.
>       * tests/nonrecursive.at, tests/recursive.at, tests/subproject.at:
>       Add new dist tests to prevent a regression.