Re: lily-guile: Attempt to determine tonality of transposed scale

[Graham Percival]

On Sun, 25 May 2003 19:49:18 +0200
Han-Wen Nienhuys <address@hidden> wrote:
>       (define-public (major-key pitch-list)
>         "Characterise the key as major if the alteration of the 
>       third scale note is the same as that of the main note.
>       Note: MIDI cannot handle other tonalities than major/minor.
>       "
>         ;; This charactersition is only true for a scale that starts
>         at `c'.(if (not (equal? (car pitch-list) '(0 . 0)))
>             (begin
>               (ly:warn "Attempt to determine tonality of transposed scale")
>               #t)
>             (eq? (cdr (list-ref pitch-list 4)) (cdr (list-ref
>             pitch-list 6)))))
> 
> This an algorithm which seems completely bogus to me. I think we
> should scrap it. How about simply outputting everything as a major
> scale?

I don't know a lot about MIDI... what difference does it make if a piece
if outputted as major or minor, assuming that all notes have the correct
pitch value?  Is it for specialized MIDI equipment that uses non-equal
temperament tuning?

Cheers,
- Graham