Re: [PATCH] Flexible accidentals code from /dev/rune

[Han-Wen Nienhuys]

On Thu, Aug 21, 2008 at 1:28 PM, Joe Neeman <address@hidden> wrote:

>>         "Checks the need for an accidental and a 'restore' accidental 
>> against a"
>> +          " key signature.  The laziness is the number of bars for
>> which reminder"
>> +          " accidentals are used (ie. if laziness is zero, we only
>> cancel accidentals"
>> +          " in the same bar; if laziness is three, we cancel
>> accidentals up to three"
>> +          " bars after they first appear.  Octaveness is either
>> 'same-octave or"
>> +          " 'any-octave and it specifies whether accidentals should
>> be canceled in"
>> +          " different octaves.")
>>
>> isn't this supposed to be texi ?
>
> I'm not sure what this means...

the doc strings are in texinfo format, with @var{foo} for variable
names, @code{'symbol} etc.

>> +  (if (number? (car entry))
>> +      #f
>> +      (caddr entry)))
>>
>> I think you can write (and CONDITION VALUE) - or in this case (and
>> (not cond) value)
>
> Is it ok if I leave this as-is? Maybe it's because I'm not really a
> schemer, but I find this much clearer.

We can always postpone it, but in general shorter code is preferable.



-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen