Re: [PATCH] Contemporary music: overview of new specialist notationsection

[Trevor Daniels]

Hi Joe, you wrote Friday, September 04, 2009 12:42 AM


> As discussed on the -user list, this is a patch to start a section 
> in
> the Specialist Notation chapter on contemporary music.
>
> I really hope that this patch (or rather, this email containing 
> the
> patch:-) has avoided the DOS line endings.  I've tested it on a 
> fresh
> git branch by emailing it to myself with new Thunderbird settings 
> and it
> applies cleanly.

The inline copy has gone now :), but the Content-transfer-encoding
is still 7-bit, which I think is relevant, and it still had DOS line 
endings.

I've now learnt quite a bit about the effect of this.  It gives 
rise to a
variety of quite misleading error messages from git am - nothing
simple like 'patch has DOS line endings', which would seem easy
to detect - but messages like

'bad git-diff - expected /dev/null on line 10'

or errors reporting trailing white space when there is none.

I changed the line endings to Unix and the patch applied cleanly.

I'll push to origin/master, so if you make any of the amendments
Graham suggested do that as a patch from this change.

> If not, further work on this section may be slightly delayed as I 
> seek
> out Thunderbird developers to beat over the head until they offer 
> a
> solution ...

Looks like that's the next step now.

Trevor