lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make tab-note-heads and fretboards use common code. (issue186268)


From: Neil Puttock
Subject: Re: Make tab-note-heads and fretboards use common code. (issue186268)
Date: Tue, 26 Jan 2010 22:49:57 +0000

2010/1/26 Carl Sorensen <address@hidden>:

> Should this be a separate patch, probably applied before the current patch?

Definitely a separate patch, though I think it can wait until this
patch has been sorted.

> I tried scm_call_5, and got a compile error.  Then I looked at the guile
> page, and no scm_call_5, nor a scm_call_n.
>
> git grep scm_call_5 returns nothing.
>
> So does git grep scm_call_n.
>
> How can I use scm_call_5 or scm_call_n?  (Although I think the solution I
> got is actually just as good).

Sorry, I must've been completely befuddled last night; I was thinking
of scm_list_5/scm_list_n, which are obviously no use in this
situation.

> Yes, I found and fixed those.  This question was about lines 235-239

Oops. :)

>  (define placement-list->....
>   "Convert .....
>   (map (lambda (x) (...)
>        (filter ((lambda (l) ...) placement-list))))
>
> That indentation seems to me to be correct.

The docstring and body are out by one space, (same for the docstring
in get-predefined-fretboard).

Cheers,
Neil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]