[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Absolute dynamics as postfix text (issue2220041)
From: |
n . puttock |
Subject: |
Re: [Patch] Absolute dynamics as postfix text (issue2220041) |
Date: |
Wed, 15 Sep 2010 20:08:15 +0000 |
Hi Valentin,
I like the markup command, but I don't see the need for adding another
keyword just to avoid the inconvenience of using a dash before the
command.
What's wrong with the following?
myDynamic =
#(define-music-function (parser location dyn) (markup?)
(make-music 'AbsoluteDynamicEvent
'text (cond
((string? dyn)
(if (string-every char-set:dynamics dyn)
dyn
(markup #:dynamic-string dyn)))
(else dyn))))
moltoF = -\myDynamic "molto_f"
\relative c' {
c1\moltoF
}
OK, so this isn't as clean a solution (and might confuse users who don't
understand the distinction between parser keywords and music function
identifiers), but it works fine. It's good enough for things like
\tweak and \bendAfter so why make dynamics a special case?
Cheers,
Neil
http://codereview.appspot.com/2220041/
- Re: [Patch] Absolute dynamics as postfix text (issue2220041), (continued)