lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc: move non-Western languages to world.itely (issue2735044)


From: v . villenave
Subject: Re: Doc: move non-Western languages to world.itely (issue2735044)
Date: Fri, 29 Oct 2010 11:58:00 +0000

Hi guys,

here's a new patch set.  In case that wasn't clear, this commit is
mainly intended as a structural change (hence the de/es/fr docs update):
as suggested by Graham, the new subsection in world.itely was blindly
copied from pitches.itely and hasn't been adapted *at all* yet.


http://codereview.appspot.com/2735044/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/pitches.itely#newcode459
Documentation/notation/pitches.itely:459: @item @file{nederlands}
On 2010/10/29 10:15:46, Trevor Daniels wrote:
As these and the following similar cases are no longer files I think
@code{nederlands} would be more appropriate.

Indeed.

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/pitches.itely#newcode538
Documentation/notation/pitches.itely:538: for quarter tones in various
languages; here the prefixes
On 2010/10/29 10:37:16, Graham Percival wrote:
why remove the hyphen?  It should be "quarter-tones", or more strictly
"quarter-tone accidentals".

Indeed.

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/pitches.itely#newcode564
Documentation/notation/pitches.itely:564: Western classical music, also
referred to as @q{Common Practice
On 2010/10/29 10:15:46, Trevor Daniels wrote:
It would be good to have a Glossary entry for CPP

Indeed.

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/world.itely#newcode28
Documentation/notation/world.itely:28: @c TODO: adapt & expand. -vv
On 2010/10/29 10:37:16, Graham Percival wrote:
Delegate this to somebody who knows about this stuff, and make it more
obvious
that we could use help with this.  Eliminate the TODO, and just add a
new issue
for "write stuff about non-common period practice tuning systems".


I'm not sure that eliminating the TODO is a good idea, at least not yet.
 I'd suggest to add a new issue for "write stuff about that, and
eliminate the TODO when you're done."

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/world.itely#newcode31
Documentation/notation/world.itely:31: traditional musics) employ
alternative or extended tuning
On 2010/10/29 10:15:46, Trevor Daniels wrote:
Don't use 'musics' - it's not English.  'Many non-Western styles of
music (and
some Western folk and traditional styles) employ ...'

It's not mine.  In case you guys haven't noticed, all I did so far is a
blind cut&paste.  I do plan to work on this subsec once this patch is
approved (if ever).

http://codereview.appspot.com/2735044/diff/1/Documentation/notation/world.itely#newcode55
Documentation/notation/world.itely:55: @c TODO: can we include the
actual accidentals in this table?
On 2010/10/29 10:37:16, Graham Percival wrote:
Eliminate the TODO, and what do you actually mean by this?

Don't know. Ask Joseph?
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commitdiff;h=bd762aff5a079bc585a3233c09b62bb2c1c3d312

http://codereview.appspot.com/2735044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]