[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Avoid most double slashes
From: |
Francisco Vila |
Subject: |
Re: [PATCH] Avoid most double slashes |
Date: |
Tue, 1 Feb 2011 15:36:21 +0100 |
2011/2/1 Francisco Vila <address@hidden>:
> Hello. I've been very busy parsing doc logs and there is something
> thatkind of annoys me: double slashes everywhere. IMHO directories in
> build scripts should end in their bare names if they are going to be
> joined with a filename by means of a slash anyway, NOT end in slash
> 'just in case'.
>
> I know that you shouldn't fix what doesn't need fixing; at least this
> does not break anything, this is the test I've made with the patch
> applied:
>
> time ( make clean && ./autogen.sh && make && make doc-clean && make doc )
>
> [32Mb of output later...]
>
> Mirroring...
> Processing HTML pages for offline target...
> find ./out-www/offline-root -type l | xargs rm -f
> make[1]: Leaving directory `/home/fravd/source/lilypond'
>
> real 105m17.622s
> user 93m34.935s
> sys 10m16.579s
>
> So the program builds, the docs build and look good, and 'make
> install' succeeds.
>
> Attached.
OOPS! here is the right patch. Sorry!
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com
0001-Build-end-directories-in-their-bare-names-and-avoid-.patch
Description: Text Data