Re: [PATCH] Avoid most double slashes

[Francisco Vila]

2011/2/1 Graham Percival <address@hidden>:
> On Tue, Feb 01, 2011 at 03:36:21PM +0100, Francisco Vila wrote:
>> 2011/2/1 Francisco Vila <address@hidden>:
>> > Hello.  I've been very busy parsing doc logs and there is something
>> > thatkind of annoys me: double slashes everywhere.  IMHO directories in
>> > build scripts should end in their bare names if they are going to be
>> > joined with a filename by means of a slash anyway, NOT end in slash
>> > 'just in case'.
>
> How annoying is this?  I agree that the output is annoying, but I
> quite like seeing them in the makefiles.  I mean, look at this:
>
>> -     $(buildscript-dir)/output-distance --create-images --output-dir 
>> $(RESULT_DIR) input/regression/out-test-baseline input/regression/out-test/
>> +     $(buildscript-dir)/output-distance --create-images --output-dir 
>> $(RESULT_DIR) input/regression/out-test-baseline input/regression/out-test
>
> is out-test a file or a directory?  I mean, output-distance could
> be writing a logfile called "out-test".

Yes.  But if out-test-baseline is a directory, also is out-test. The
former came w/o slash, looks poor that the latter comes with.

>  IMO, removing all the
> extra slashes means that the makefiles are slightly less readable,
> and requires slightly more familiarity and memorization of the
> build process.
>
> of course, the whole thing is a mess anyway, so you could argue
> that it doesn't matter if we make it messier.

No, this is not my argument.  My aim is to be slightly more coherent
and not put random, unneeded slashes at the end.

> It's something we can (and should) avoid if we ever reach a
> critical mass of developers sufficiently fed up with the current
> build system that we can realistically create a new one, but until
> then, my instinct is to leave it alone.

That's why you didn't do it, my instinct was to improve it and that's
why I did it.  Ah, that did not end the whole sroty because many
double slashes still remain, I must say.

If the commit has not been truly harmless (it's been for me but it's
not been proven it's for everybody) let's revert it.

-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com