Re: [PATCH] Avoid most double slashes

[Graham Percival]

On Tue, Feb 01, 2011 at 03:36:21PM +0100, Francisco Vila wrote:
> 2011/2/1 Francisco Vila <address@hidden>:
> > Hello.  I've been very busy parsing doc logs and there is something
> > thatkind of annoys me: double slashes everywhere.  IMHO directories in
> > build scripts should end in their bare names if they are going to be
> > joined with a filename by means of a slash anyway, NOT end in slash
> > 'just in case'.

How annoying is this?  I agree that the output is annoying, but I
quite like seeing them in the makefiles.  I mean, look at this:

> -     $(buildscript-dir)/output-distance --create-images --output-dir 
> $(RESULT_DIR) input/regression/out-test-baseline input/regression/out-test/
> +     $(buildscript-dir)/output-distance --create-images --output-dir 
> $(RESULT_DIR) input/regression/out-test-baseline input/regression/out-test

is out-test a file or a directory?  I mean, output-distance could
be writing a logfile called "out-test".  IMO, removing all the
extra slashes means that the makefiles are slightly less readable,
and requires slightly more familiarity and memorization of the
build process.

of course, the whole thing is a mess anyway, so you could argue
that it doesn't matter if we make it messier.

*shrug*


It's something we can (and should) avoid if we ever reach a
critical mass of developers sufficiently fed up with the current
build system that we can realistically create a new one, but until
then, my instinct is to leave it alone.

Cheers,
- Graham