Re: http://codereview.appspot.com/3667041

[Carl Sorensen]

On 2/4/11 9:26 AM, "James Lowe" <address@hidden> wrote:

> Carl,
> 
> -----Original Message-----
> From: Carl Sorensen [mailto:address@hidden
> Sent: 04 February 2011 14:31
> To: James Lowe; address@hidden
> Subject: Re: http://codereview.appspot.com/3667041
> 
> I think that for purposes of giving credit where it's due, it would be nice to
> see if you can apply it in two patches -- one that has Mark's stuff, and the
> other that has yours.
> 
> ---
> 
> Actually it will be *all* Mark's work. I'm just editing it for terseness/NR
> style.

No, your edits of his work will be *your* work.

We're not ready to push the patch in its current state.  By the time it's
ready to be pushed it will be a mix of your work and his work.

Maybe the right thing to do is keep it in two separate patches, so that when
it's approved we'll push two patches -- one that is the current state of the
patch (your starting point) and another that is the final state of the
patch.  If we push them both at the same time we'll keep the credit and
never have a current git with the unapproved state active.

Thanks,

Carl