[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: improving the transition between full-length and shortened stems. (i
|
From: |
Janek Warchoł |
|
Subject: |
Re: improving the transition between full-length and shortened stems. (issue4210051) |
|
Date: |
Sun, 27 Feb 2011 08:29:07 +0100 |
2011/2/27 Han-Wen Nienhuys <address@hidden>
>
> 2011/2/26 Janek Warchoł <address@hidden>:
>
> http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode360
> >> lily/stem.cc:360: Real shortening_step = min (max (0.25,
> >> (shorten_property / 6)), 0.5);
> >> shouldnt 6 be 2*staff_radius+1 ?
> >
> > No, radius of default staff is 2, so 2*staff_radius+1 = 5 != 6
>
> well, 2*radius+2 then? Anything that indicates how this number is formed is
> ok.
Ah, sorry. I missed what you meant.
Well, this nuber is not formed :) It shouldn't depend on staff_radius.
This number determines what the steepness of transition should be
(i.e., what the angle of the red line in the attachment will be). This
angle shouldn't depend on Staff_radius in my opinion.
cheers,
Janek
steepness.PNG
Description: PNG image
steepness.PNG