Re: improving the transition between full-length and shortened stems. (issue4210051)

[Janek Warchoł]

2011/2/25 <address@hidden>

LGTM

just cosmetics.


http://codereview.appspot.com/4210051/diff/1/lily/stem.cc
File lily/stem.cc (right):

http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode336
lily/stem.cc:336: SCM s = ly_assoc_get (ly_symbol2scm ("lengths"),
details, SCM_EOL);
can you rename this for easier readability?

ok

http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode360
lily/stem.cc:360: Real shortening_step = min (max (0.25,
(shorten_property / 6)), 0.5);
shouldnt 6 be 2*staff_radius+1 ?

No, radius of default staff is 2, so 2*staff_radius+1 = 5 != 6

 

http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode368
lily/stem.cc:368: which_step += abs(hp[dir]);
can you collapse these 3 lines?

I thought it will be easier to understand this way, but no problem. 

I'll fix these probably on wednesday - unfortunately i haven't configured my home computer properly and i cannot access it via remote desktop :( Sorry for the delay.

cheers,

Janek