[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: improving the transition between full-length and shortened stems. (i
|
From: |
hanwenn |
|
Subject: |
Re: improving the transition between full-length and shortened stems. (issue4210051) |
|
Date: |
Fri, 25 Feb 2011 14:53:01 +0000 |
LGTM
just cosmetics.
http://codereview.appspot.com/4210051/diff/1/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode336
lily/stem.cc:336: SCM s = ly_assoc_get (ly_symbol2scm ("lengths"),
details, SCM_EOL);
can you rename this for easier readability?
http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode360
lily/stem.cc:360: Real shortening_step = min (max (0.25,
(shorten_property / 6)), 0.5);
shouldnt 6 be 2*staff_radius+1 ?
http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode368
lily/stem.cc:368: which_step += abs(hp[dir]);
can you collapse these 3 lines?
http://codereview.appspot.com/4210051/
- Re: improving the transition between full-length and shortened stems. (issue4210051),
hanwenn <=