lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)


From: pkx166h
Subject: Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)
Date: Fri, 25 Feb 2011 14:17:26 +0000

Third draft done - sorry it took so long.


http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode541
Documentation/notation/input.itely:541: outside of the first
@code{\score} of a book, and individual title
On 2011/02/15 01:28:04, Graham Percival wrote:
I'm not certain about the word "outside".  Do you have a strong
preference
against "above" ?

Not especially.

Done.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode586
Documentation/notation/input.itely:586: @code{print-all-headers = ##t}
inside a @code{\paper} block.
On 2011/02/15 01:28:04, Graham Percival wrote:
Don't talk through the code.

Done.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode589
Documentation/notation/input.itely:589: blocks by adding @code{##f} to
the Text field.
On 2011/02/15 01:28:04, Graham Percival wrote:
Don't talk through the code.

Done.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode590
Documentation/notation/input.itely:590:
On 2011/02/15 01:28:04, Graham Percival wrote:
Replace the previous two paragraphs with this:

Text fields from the main title block of a book can be displayed in
all
@code{\score} blocks, or manually suppressed:

Thanks...done.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode599
Documentation/notation/input.itely:599: tagline = ##f
On 2011/02/15 01:28:04, Graham Percival wrote:
If you want to clarify this, add a comment above this line.
% do not this text field:

Good idea. Also did this for the next two scores in this example just
for consistency.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode641
Documentation/notation/input.itely:641: @code{bookTitleMarkup} for the
main title block and
I've taken a look at this - before I had just edited the existing
paragraphs - and have I hope simplified this part of the section by
removing the itemization and condensing it into a para and better
comments in the @lilypond so that those 95% of users get what they want.


See what you think with regard to the other comments and if we still
need to move information to new nodes or not, it may give a different
perspective.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode650
Documentation/notation/input.itely:650: These markup variables access
text fields from the @code{\header}
See comment above.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode656
Documentation/notation/input.itely:656: Settings for
@code{bookTitleMarkup}:
See comment above.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode689
Documentation/notation/input.itely:689: The default settings for
@code{scoreTitleMarkup} place the @code{piece}
I personally don't normally like itemizing things, but see comments
above as I have, I hope simplified this for readers.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode691
Documentation/notation/input.itely:691:
Again see comments above. I've incorporated this with the first
@lilypond just so it is all in one example.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode707
Documentation/notation/input.itely:707: @end example
On 2011/02/15 01:28:04, Graham Percival wrote:
I'd rather have a @lilypond.

I think until I can get a way to

1. Incorporate a small custom page in page.scm and
2. Somehow get @lilypond to allow a [pagesize=x,] option I am not sure
how I can do this without massive white space for a 'real' page break.
So for now I haven't done this.

http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode767
Documentation/notation/input.itely:767: @node Custom headers footers and
titles
On 2011/02/15 01:28:04, Graham Percival wrote:
I'm ignoring this subsection for now; let's focus on the first one.

No problem, but I am hoping that we can make this like the section above
after my edits.

http://codereview.appspot.com/4124056/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]