Re: Bugfix for issue 1630 (issue4490045)

[n . puttock]

http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):

http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc#newcode204
lily/completion-note-heads-engraver.cc:204:
event->set_property("autosplit-remainder", Moment(left_to_do_ -
note_dur.get_length ()).smobbed_copy ());
Wouldn't this work equally well as a boolean?

As far as I can see, the Tie_engraver only reads this property, checking
whether main_part_ is > 0, so this test could be done here instead,
e.g.,

if (Moment (left_to_do_ - note_dur.get_length)).main_part_)
  event->set_property ("autosplit-remainder", SCM_BOOL_T);

(obviously this would mean renaming this property)

http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc
File lily/tie-engraver.cc (right):

http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode121
lily/tie-engraver.cc:121: Determines whether the end of an event was
created by
indent

http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode168
lily/tie-engraver.cc:168: Make a tie only if pitches are equal or if
event end was not generated by
indent

http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode172
lily/tie-engraver.cc:172: &&
(!Tie_engraver::has_autosplit_end(left_ev)))
indent

http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode261
lily/tie-engraver.cc:261: */
indent

http://codereview.appspot.com/4490045/diff/1/lily/tie-engraver.cc#newcode294
lily/tie-engraver.cc:294: &&
(!Tie_engraver::has_autosplit_end(left_ev)))
indent

space before (left_ev)

http://codereview.appspot.com/4490045/