Re: Bugfix for issue 1630 (issue4490045)

[Carl . D . Sorensen]

On 2011/05/28 16:13:43, benko.pal wrote:
> aargh, that's not too readable.
> what I actually suggest is replacing lines 204-207 of

> >

http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
> > File lily/completion-note-heads-engraver.cc (right):

> 204       if ((left_to_do_ - note_dur.get_length ()) > Rational (0))
> 205         event->set_property("autosplit-end", ly_bool2scm (true));
> 206       else
> 207         event->set_property("autosplit-end", ly_bool2scm (false));

> by

>     event->set_property ("autosplit-end",
>       ly_bool2scm (left_to_do_ - note_dur.get_length () >
0));

> Pal

That was the original code.  It was pointed out (see Neil's comment
above) that the only check on this is whether or not it is greater than
zero, so a boolean works.  Hence, the code was changed to use a boolean.

http://codereview.appspot.com/4490045/