lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bugfix for issue 1630 (issue4490045)


From: karin . hoethker
Subject: Re: Bugfix for issue 1630 (issue4490045)
Date: Mon, 09 May 2011 19:41:31 +0000


http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):

http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc#newcode204
lily/completion-note-heads-engraver.cc:204:
event->set_property("autosplit-remainder", Moment(left_to_do_ -
note_dur.get_length ()).smobbed_copy ());
Indeed, using a boolean would be the minimal solution. However, the
remaining duration is related to the current time and the overall note
duration etc. If for example tuplet splitting was to be implemented for
the Completions_heads_engraver, the remainder could be useful in a
splitting strategy.
It depends on whether minimal data structures or minimal renaming of
variables is preferred in lilypond development. I don't know about that
...

http://codereview.appspot.com/4490045/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]