[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GOP-PROP 3: C++ formatting
From: |
address@hidden |
Subject: |
Re: GOP-PROP 3: C++ formatting |
Date: |
Wed, 22 Jun 2011 08:43:37 +0200 |
On Jun 22, 2011, at 2:54 AM, Keith OHara wrote:
> Graham Percival <graham <at> percival-music.ca> writes:
>
>> This one will be contentious.
>
> Maybe the various opinions will share a small overlapping area of consensus;
> applying even a small improvement might be enough to make life easier.
>
>> ** Eliminate tabs
>>
> That helps (even though editors should handle tabs for us) because it removes
> the need to re-configure our editors when we switch projects.
>
>
>> My preference is just to say
>> "let’s just use fixcc.py strictly".
>
> Even those of us who fear emacs could probably run that script on changed .cc
> .hh files before each commit. We will forget sometimes, but any reviewer
> comments on indentation could be a simple "Don't forget to fixcc.py before
> you
> push."
>
>> No plan for how to do this yet; it will be a mess.
>>
> Maybe just let us fixcc.py on changed files on new commits.
> In any case, we will need to start using git blame -w (ignore whitespace)
> to research the history of the code.
>
I agree, and I think we can use it periodically on the entire source in case
people forget to format their patches before pushing.
Cheers,
MS
- GOP-PROP 3: C++ formatting, Graham Percival, 2011/06/21
- Re: GOP-PROP 3: C++ formatting, Keith OHara, 2011/06/21
- Re: GOP-PROP 3: C++ formatting, Jan Warchoł, 2011/06/22
- Re: GOP-PROP 3: C++ formatting, Graham Percival, 2011/06/22
- Re: GOP-PROP 3: C++ formatting, Jan Warchoł, 2011/06/22
- Re: GOP-PROP 3: C++ formatting, Graham Percival, 2011/06/22
- Re: GOP-PROP 3: C++ formatting, Carl Sorensen, 2011/06/22
- Re: GOP-PROP 3: C++ formatting, Jan Warchoł, 2011/06/25
- Re: GOP-PROP 3: C++ formatting, Graham Percival, 2011/06/25
- Re: GOP-PROP 3: C++ formatting, Jan Warchoł, 2011/06/25