Re: GOP-PROP 3: C++ formatting

[Keith OHara]

On Mon, 27 Jun 2011 10:37:10 -0700, Graham Percival <address@hidden> wrote:

> When I look at
>   git diff origin/dev/gperciva-fixcc origin/dev/gperciva-astyle
> I'm still leery about some changes.

Some indentation is off because fix-astyle-fiddle removes spaces after 
indentation.  (fixcc.py does *pre*-processing to tweak the spacing, then asks 
emacs to indent.)  Also, astyle changes less than fixcc.py, so variability in 
the original files show up on the astyle side in the diff.  There might be 
other astyle options to resolve whatever made you leery; I didn't find anything 
leerifying.

Too bad that astyle doesn't do the "foo ((void *)bar)" quite right.


I notice that fixcc.py :

1) Left-aligns our multiline comments (skyline.cc : 29)
We could start continuation lines with * when alignment matters

2) Line-breaks before ; after a single-statement do-while (line-spanner.cc : 
273)
We need braces in these cases to conform to gnu standard
 do
   {
      a++;
   }
 while (a < 10);

3) Needs extra parentheses to indent continued lines nicely (beam.cc : 628)
 long_variable_name = (long_function_name (right)
                       - long_function_name (left));

4) Moves the '=' to the second line if there was a linebreak 
(ambitus-engraver.cc : 158)
  Grob *thingy
    = lengthy_initializer ();

5) Spaces out templates in odd ways(flower/include/std-vector.hh : 81)
 template < typename T>
This is probably a regexp problem

6) Fails to add missing space after comma (accidental-engraver.cc : 410)
This just a bug in the regexp, where some \( should be (

The only one that concerns me is left-aligning those comments