[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Separate flags into their own sub-font. (issue4654084)
|
From: |
lemniskata . bernoullego |
|
Subject: |
Re: Separate flags into their own sub-font. (issue4654084) |
|
Date: |
Mon, 04 Jul 2011 20:19:31 +0000 |
LGTM!
Thank you, Carl!
http://codereview.appspot.com/4654084/diff/42/mf/feta-flags-generic.mf
File mf/feta-flags-generic.mf (right):
http://codereview.appspot.com/4654084/diff/42/mf/feta-flags-generic.mf#newcode4
mf/feta-flags-generic.mf:4: % Copyright (C) 1997--2011 Han-Wen Nienhuys
<address@hidden>
Shouldn't your name be here, Carl?
http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1450
mf/feta-scripts.mf:1450: begingroup;
You added this because every glyph should be in some group now?
http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1452
mf/feta-scripts.mf:1452: height# := staff_space#;
are the colons only a matter of style?
http://codereview.appspot.com/4654084/