Re: Adapt fixcc.py to use Astyle and/or emacs (issue4662074)

[Trevor Daniels]

address@hidden wrote Thursday, July 14, 2011 5:33 AM


> It seems everyone is happy to use astyle as the indenter
> (it sure is faster) so here is one last patch set showing what 
> this does
> to the sample set of C++ files.
>
> Running fixcc(astyle) on the source tree again gives a clean make 
> check.

I was hoping to recommend going with this, so we could
wrap up this issue, but then I found

- new_context->event_source ()->
-   add_listener (GET_LISTENER 
(new_context->create_context_from_event),
+ new_context->event_source ()->
+ add_listener (GET_LISTENER 
(new_context->create_context_from_event),

which looks wrong to me (by any measure of code clarity).

There are examples of this in lily/context.cc

Trevor