Re: Doc: NR Added new Node for Footnotes (issue4751045)

[n . puttock]

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1024
Documentation/notation/input.itely:1024: for top-level @code{\markup}s
and @code{\footnoteGrob} for individual
for for

\footnote is two separate commands; one for top-level markup (defined as
a markup command) and the other a \balloon-style music function.  The
latter is the only way to add a footnote to an individual notehead in a
chord, e.g.,

\relative c' {
  <c es-\footnote #'(2 . 4) \markup \box "a" "a. E flat" >1
}

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1031
Documentation/notation/input.itely:1031: \footnoteGrob  #'@var{Layout
Object} #'@var{(x . y)}
remove extra space before #

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1053
Documentation/notation/input.itely:1053: \markup { \teeny 2 }  \markup {
2. \bold Forte }
remove extra space before \markup

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1074
Documentation/notation/input.itely:1074: \markup { " " }
\markup { \null }

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1079
Documentation/notation/input.itely:1079: The order in which LilyPond
creates each grob, determines the order that
don't mention LilyPond

remove comma

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1094
Documentation/notation/input.itely:1094: Notation Reference:
Add Internals Reference links:

FootnoteEvent
FootnoteItem
FootnoteSpanner
Footnote_engraver

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1102
Documentation/notation/input.itely:1102: attached to the @emph{first
instance} of a clef, time or key signature
Sure they can:

\new Staff \with {
  \consists "Footnote_engraver"
}
\relative c' {
  \footnoteGrob #'Clef #'(0 . 2) "1." "1. Treble clef"
  \footnoteGrob #'KeySignature #'(0 . -2) "2." "2. G flat major"
  \footnoteGrob #'TimeSignature #'(0 . 2) "3." "3. Common time"
  \key ges \major
  des1
}

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1103
Documentation/notation/input.itely:1103: nor @code{TextScript} objects,
barlines or @code{MultiMeasureRests} and
TextScript and BarLine work fine via \footnoteGrob

http://codereview.appspot.com/4751045/diff/8001/Documentation/snippets/new/footnote-break-visibility.ly
File Documentation/snippets/new/footnote-break-visibility.ly (right):

http://codereview.appspot.com/4751045/diff/8001/Documentation/snippets/new/footnote-break-visibility.ly#newcode5
Documentation/snippets/new/footnote-break-visibility.ly:5: Footnotes
attached to grobs that have their break visibility set, will
remove comma

http://codereview.appspot.com/4751045/diff/8001/Documentation/snippets/new/footnote-break-visibility.ly#newcode6
Documentation/snippets/new/footnote-break-visibility.ly:6: be printed on
both grob resulting in duplicate footnotes but this
grobs

http://codereview.appspot.com/4751045/diff/8001/Documentation/snippets/new/footnote-break-visibility.ly#newcode29
Documentation/snippets/new/footnote-break-visibility.ly:29: \once
\override Staff.FootnoteItem #'break-visibility = ##(#f #f #t)
#'break-visibility = #end-of-line-invisible

http://codereview.appspot.com/4751045/