Re: Doc: NR Added new Node for Footnotes (issue4751045)

[pkx166h]

Thanks for the input, I have some questions about three of the
corrections/suggestions.


http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1024
Documentation/notation/input.itely:1024: for top-level @code{\markup}s
and @code{\footnoteGrob} for individual
On 2011/07/17 20:37:44, Neil Puttock wrote:
> for for

Done.


> \footnote is two separate commands; one for top-level markup (defined
as a
> markup command) and the other a \balloon-style music function.  The
latter is
> the only way to add a footnote to an individual notehead in a chord,
e.g.,

> \relative c' {
>    <c es-\footnote #'(2 . 4) \markup \box "a" "a. E flat" >1
> }

Ok I tried

\relative c' {
  <c \footnoteGrob #'NoteHead #'(2 . 4) \markup \box "a" "a. E flat" es
> 1 } for myself and it works but I get two indicators and two footnotes
on each note inside the chord. So is this a special case? If so then I
can add a snippet or another @lilypond to illustrate this.

As you have a more deeper knowledge of why I'd get multiple instances of
a footnote indicator, I'm wondering do we need a \footnoteGrob command
at all? or rather I'm struggling why < ... > constructs make this
exception. Perhaps then I can elaborate more somewhere in this section.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1031
Documentation/notation/input.itely:1031: \footnoteGrob  #'@var{Layout
Object} #'@var{(x . y)}
On 2011/07/17 20:37:44, Neil Puttock wrote:
> remove extra space before #

Done.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1038
Documentation/notation/input.itely:1038: where the @code{\markup
@address@hidden is printed.  One line is drawn
On 2011/07/17 22:27:32, Trevor Daniels wrote:
> The @code{\markup @address@hidden is printed offset from the center of
the grob
> that is being footnoted by the value of the @code{#'(x . y)} argument.

> [I don't think we need the bit about lines and the position of the
footnote -
> these should be obvious from the following @lilypond.]

Done.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1053
Documentation/notation/input.itely:1053: \markup { \teeny 2 }  \markup {
2. \bold Forte }
On 2011/07/17 20:37:44, Neil Puttock wrote:
> remove extra space before \markup

Done.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1074
Documentation/notation/input.itely:1074: \markup { " " }
On 2011/07/17 20:37:44, Neil Puttock wrote:
> \markup { \null }

Done.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1079
Documentation/notation/input.itely:1079: The order in which LilyPond
creates each grob, determines the order that
On 2011/07/17 20:37:44, Neil Puttock wrote:
> don't mention LilyPond

> remove comma

Done.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1094
Documentation/notation/input.itely:1094: Notation Reference:
On 2011/07/17 20:37:44, Neil Puttock wrote:
> Add Internals Reference links:

> FootnoteEvent
> FootnoteItem
> FootnoteSpanner
> Footnote_engraver

Done.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1102
Documentation/notation/input.itely:1102: attached to the @emph{first
instance} of a clef, time or key signature
On 2011/07/17 20:37:44, Neil Puttock wrote:
> Sure they can:

> \new Staff \with {
>    \consists "Footnote_engraver"
> }
> \relative c' {
>    \footnoteGrob #'Clef #'(0 . 2) "1." "1. Treble clef"
>    \footnoteGrob #'KeySignature #'(0 . -2) "2." "2. G flat major"
>    \footnoteGrob #'TimeSignature #'(0 . 2) "3." "3. Common time"
>    \key ges \major
>    des1
> }

OK Mike said it couldn't, :)

Done.

PS.

Is it a silly question to ask why this engraver isn't in the Staff
context by default? or can an engraver be in more than one at once?

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1103
Documentation/notation/input.itely:1103: nor @code{TextScript} objects,
barlines or @code{MultiMeasureRests} and
On 2011/07/17 20:37:44, Neil Puttock wrote:
> TextScript and BarLine work fine via \footnoteGrob


Yes I see that now when we use a staff context.

Removed.

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1105
Documentation/notation/input.itely:1105:
On 2011/07/17 20:48:05, MikeSol wrote:
> A way to make them not collide with bordering staves is to give them
Y-extents
> (currently they are set to have no Y extent).

snippet I could add - make a simple example and I can do something with
it?

http://codereview.appspot.com/4751045/