Re: review process not working

[Jan Nieuwenhuizen]

David Kastrup writes:

> The overall code makes obvious that this has been created by a
> comparative novice to the programming languages and data structures of
> Lilypond.  He has been doing his best.

Good catch.  The patch also

@@ -208,63 +221,46 @@ Multi_measure_rest::church_rest (Grob *me, Font_metric 
*musfont, int measures,
 {
   SCM mols = SCM_EOL;
 
-  /* See Wanske pp. 125  */
   int l = measures;
   int count = 0;

removes a reference to literature, which is very bad.  Although I agree
that the comment could elaborate a bit on what Wanske says on page 125,
I don't think we want this kind of references removed.

I think this patch should be reverted, moved to Rietveld, and worked on.

Jan

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl