Re: review process not working

[David Kastrup]

Graham Percival <address@hidden> writes:

> On Tue, Jul 26, 2011 at 12:05:31PM +0200, David Kastrup wrote:
>
>> Perhaps a minimal measure of sanity would be if a patch countdown
>> without code review was only started when the author of the patch
>> says "I feel reasonably confident that this not just works, but is
>> good".
>> 
>> In git, there is the "formal" sanctification of "Signed-off-by".
>> Perhaps we should not start a patch countdown on any patch that has
>> not been signed off by anybody?
>
> I speak against this, at least for now.  This is a question of
> balance between support for new contributors (i.e. mentors, of
> which we have far fewer than I would like), amount of available
> reviewers (which is smaller than we would like), and the moral of
> contributors.

A contributor is free to add "Signed-off-by" himself.  I was talking
about patches that not even the contributor feels confident enough about
to undersign it.

> This is a different problem.  Am I correct in reading that it
> "passed" the regtests but added some warnings?

Well, I am rather positive I saw warnings about the referenced rest
glyphs not being found (that made me look in the code in the first
place).  My first contention, that writing "-" for "M" was the culprit
was wrong since the glyph lookup explicitly replaces "-" with "M".  The
messages are


Processing `./3c/lily-e6c82577.ly'
Parsing...
Renaming input to: `rest-ledger.ly'
Interpreting music... 
Preprocessing graphical objects...
Calculating line breaks... 
Drawing systems... 
rest-ledger.ly:22:2: warning: rest `rests.-1o' not found
  
  r
rest-ledger.ly:19:2: warning: rest `rests.-1o' not found
  
  r \rPos #-4
rest-ledger.ly:19:2: warning: rest `rests.-1o' not found
  
  r \rPos #-4
rest-ledger.ly:22:2: warning: rest `rests.-1o' not found
  
  r
Writing header field `texidoc' to `./3c/lily-e6c82577.texidoc'...
Writing ./3c/lily-e6c82577-1.signature
Layout output to `./3c/lily-e6c82577.eps'...
Layout output to `./3c/lily-e6c82577-1.eps'...
Writing ./3c/lily-e6c82577-systems.texi...
Writing ./3c/lily-e6c82577-systems.tex...
Writing ./3c/lily-e6c82577-systems.count...
Writing timing to 3c/lily-e6c82577.profile...

So more likely, the appended "o" is at fault.  Using
Rest::whateveritwasIsuggested would have been smart enough to avoid
appending letters not applicable to the really long rests.

-- 
David Kastrup