Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

[hanwenn]

as an overall comment; I would try to look at the buggy examples in more
detail to understand exactly what is going wrong.  It is easy to add an
extra demerit, but (as you can see) hard to make it work with all the
other cases that we handle.


http://codereview.appspot.com/4817048/diff/15002/lily/slur-configuration.cc
File lily/slur-configuration.cc (right):

http://codereview.appspot.com/4817048/diff/15002/lily/slur-configuration.cc#newcode249
lily/slur-configuration.cc:249: Real encompass_refpoint = minmax
(state.dir_, state.encompass_infos_[j].head_,
state.encompass_infos_[j].stem_);
refpoint usually has another meaning within lilypond.

http://codereview.appspot.com/4817048/diff/15002/lily/slur-configuration.cc#newcode252
lily/slur-configuration.cc:252: if (fabs (encompass_refpoint) >
highest_point
is this reasonable for non-horizontal slurs? Why don't you check for the
maximum dy instead?

http://codereview.appspot.com/4817048/diff/15002/lily/slur-configuration.cc#newcode256
lily/slur-configuration.cc:256: * 2 is the max distance allowable from
the highest notehead before
2 ?

http://codereview.appspot.com/4817048/