Re: parser.yy: rearrange to allow more lenient use of music arguments for music functions. (issue4815052)

[dak]

On 2011/07/29 08:55:24, Reinhold wrote:
> First, I have to say that I don't really understand the fine details
of the
> patch...

Makes music functions more predictable and versatile.  This started with
a patch I already pushed, implementing more argument types.

The documentation would have been quite more contorted if I had properly
documented the state previous to this patch.  I don't really want to
write that up.

> Can you give some explicit examples that your patch now allows that
didn't work
> before (preferrably as a regtest, so we notice when a future parser
change
> breaks it)?

Well, one could now move a few things like \relative and \transpose into
music functions (and Scheme-callable functions for the hard work, for
efficiency's sake).

That would be a quite reliable regtest...

> You are talking about the problems with chord constituents. How does
this work
> with \tweak, which is explicitly also meant to change single chord
constituents?

It worked previously because \tweak was a special case that matched the
previous semantics reasonably well.  \tweak works just the same as it
did previously, but it is less surprising that it does so.

> Or should tweak always be handled as a special case and not make use
of your
> parser changes?

\tweak still works just the same.  But you could, for example, write
something like
\staffposition-at d'
that resulted in a tweak of the next element to have it land in the
position of a d'.

A music function like that was just not possible previously since it
would have been beyond the narrow pattern of things that were
implemented.

http://codereview.appspot.com/4815052/