|
From: | hanwenn |
Subject: | Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072) |
Date: | Fri, 05 Aug 2011 12:08:29 +0000 |
LGTM http://codereview.appspot.com/4810072/diff/3002/input/regression/slur-height-capping.ly File input/regression/slur-height-capping.ly (right): http://codereview.appspot.com/4810072/diff/3002/input/regression/slur-height-capping.ly#newcode4 input/regression/slur-height-capping.ly:4: texidoc = "Lilypond ignores extra-collision-objects towards "slur shape is not adapted to accomodate objects towards the edges of the slurs" (we should still score for collisions) http://codereview.appspot.com/4810072/diff/3002/lily/slur-configuration.cc File lily/slur-configuration.cc (right): http://codereview.appspot.com/4810072/diff/3002/lily/slur-configuration.cc#newcode102 lily/slur-configuration.cc:102: close_to_edge = close_to_edge || -d * (p[X_AXIS] - curve_xext[d]) < close_to_edge_length; i'd simply use fabs. http://codereview.appspot.com/4810072/
[Prev in Thread] | Current Thread | [Next in Thread] |