[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes bad slur heights by limiting fit_factor to the interior of slu
From: |
mtsolo |
Subject: |
Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072) |
Date: |
Fri, 05 Aug 2011 18:15:11 +0000 |
http://codereview.appspot.com/4810072/diff/3002/input/regression/slur-height-capping.ly
File input/regression/slur-height-capping.ly (right):
http://codereview.appspot.com/4810072/diff/3002/input/regression/slur-height-capping.ly#newcode4
input/regression/slur-height-capping.ly:4: texidoc = "Lilypond ignores
extra-collision-objects towards
On 2011/08/05 12:08:29, hanwenn wrote:
"slur shape is not adapted to accomodate objects towards the edges of
the slurs"
(we should still score for collisions)
Changed.
http://codereview.appspot.com/4810072/diff/3002/lily/slur-configuration.cc
File lily/slur-configuration.cc (right):
http://codereview.appspot.com/4810072/diff/3002/lily/slur-configuration.cc#newcode102
lily/slur-configuration.cc:102: close_to_edge = close_to_edge || -d *
(p[X_AXIS] - curve_xext[d]) < close_to_edge_length;
On 2011/08/05 12:08:29, hanwenn wrote:
i'd simply use fabs.
I'm reticent to use fabs just cuz its not very lilypondish given the way
other stuff like this is written (see, for example,
get_y_attachment_range, written by a young Han-Wen Nienhuys :) )
http://codereview.appspot.com/4810072/
- Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), mtsolo, 2011/08/04
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), mtsolo, 2011/08/05
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), hanwenn, 2011/08/05
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072),
mtsolo <=
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), k-ohara5a5a, 2011/08/06
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), lemniskata . bernoullego, 2011/08/06
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), address@hidden, 2011/08/06
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), Janek Warchoł, 2011/08/07
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), address@hidden, 2011/08/07
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), Janek Warchoł, 2011/08/07
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), Graham Percival, 2011/08/07
- Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), Han-Wen Nienhuys, 2011/08/08
Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), pkx166h, 2011/08/06
Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072), k-ohara5a5a, 2011/08/07