lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improves horizontal spacing of axis groups that SpanBar grobs traver


From: hanwenn
Subject: Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)
Date: Sat, 27 Aug 2011 14:23:16 +0000

I read through this patch,  but I can't tell what it does or is supposed
to do. Maybe one of our pure gurus should look at this.  Joe?


http://codereview.appspot.com/4917046/diff/1/lily/align-interface.cc
File lily/align-interface.cc (right):

http://codereview.appspot.com/4917046/diff/1/lily/align-interface.cc#newcode399
lily/align-interface.cc:399: Align_interface::vertical_sort (Grob *g1,
Grob *g2)
this doesn't sort.

http://codereview.appspot.com/4917046/diff/1/lily/pure-from-neighbor-engraver.cc
File lily/pure-from-neighbor-engraver.cc (right):

http://codereview.appspot.com/4917046/diff/1/lily/pure-from-neighbor-engraver.cc#newcode4
lily/pure-from-neighbor-engraver.cc:4: Copyright (C) 1997--2011 Han-Wen
Nienhuys <address@hidden>
?

http://codereview.appspot.com/4917046/diff/1/lily/pure-from-neighbor-engraver.cc#newcode53
lily/pure-from-neighbor-engraver.cc:53: && !i.grob
()->internal_has_interface (ly_symbol2scm
("pure-from-neighbor-interface")))
can't you put this in acknowledge_pure_from_neighbor() so you don't have
to check the interface ?

http://codereview.appspot.com/4917046/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]